This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix ecvt_r, fcvt_r namespace (bug 18522)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Thu, 11 Jun 2015 21:57:45 -0400
- Subject: Re: Fix ecvt_r, fcvt_r namespace (bug 18522)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1506112227180 dot 15628 at digraph dot polyomino dot org dot uk>
On 06/11/2015 06:28 PM, Joseph Myers wrote:
> The functions ecvt, fcvt and gcvt, in some standards, bring in
> references to ecvt_r and fcvt_r, which aren't in any of those
> standards. The calls are correctly to __ecvt_r and __fcvt_r, but then
> the names ecvt_r and fcvt_r are defined as strong aliases; this patch
> changes them to weak aliases.
>
> Tested for x86_64 and x86 (testsuite, and that disassembly of
> installed stripped shared libraries is unchanged by the patch).
>
> 2015-06-11 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #18522]
> * misc/efgcvt_r.c
> [LONG_DOUBLE_COMPAT (libc, GLIBC_2_0) && !LONG_DOUBLE_CVT]
> (cvt_symbol): Use weak_alias instead of strong_alias.
> [LONG_DOUBLE_COMPAT (libc, GLIBC_2_0)] (cvt_symbol): Likewise.
> * conform/Makefile (test-xfail-XPG4/stdlib.h/linknamespace):
> Remove variable.
> (test-xfail-UNIX98/stdlib.h/linknamespace): Likewise.
> (test-xfail-XOPEN2K/stdlib.h/linknamespace): Likewise.
Looks good to me.
c.