This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 7/14] [x86_64] Vector math functions (log and tests)


On Wed, 10 Jun 2015, Andrew Senkevich wrote:

> +/* Workaround to exclude unnecessary symbol aliases in libmvec
> +   while GCC creates the vector names based on scalar asm name.  */

I think the GCC list discussion of possible better approaches to this 
issue should be started first, with the comment referencing the 
discussion.

> +        movsd     -4218816(%r8,%rdx), %xmm1

Where does this magic constant -4218816, that appears several times in the 
patch, come from?  It seems like something that should have a #define in a 
header, with a meaningful name and a comment explaining its semantics.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]