This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix open_memstream namespace (bug 18498)
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 5 Jun 2015 15:37:47 -0700 (PDT)
- Subject: Re: Fix open_memstream namespace (bug 18498)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1506052230060 dot 16975 at digraph dot polyomino dot org dot uk>
> +/* The prototype needs repeating instead of using __typeof to use
> + __THROW in C++. */
> +extern FILE *__open_memstream (char **, size_t *) __THROW __wur;
> +libc_hidden_proto (__open_memstream)
Does "extern __typeof (open_memstream) __open_memstream __THROW __wur;" not
work? That would be less duplication anyway. Regardless, the comment
reads as odd in its mention of C++ since there is C++ code in libc to be
calling this.
Substantively the change looks fine to me.