This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix strict-aliasing warning in resolv/res_hconf.c
- From: Roland McGrath <roland at hack dot frob dot com>
- To: <sellcey at imgtec dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, Pedro Alves <palves at redhat dot com>, Andreas Schwab <schwab at suse dot de>, Paul Eggert <eggert at cs dot ucla dot edu>, <libc-alpha at sourceware dot org>
- Date: Fri, 5 Jun 2015 13:51:04 -0700 (PDT)
- Subject: Re: [PATCH] Fix strict-aliasing warning in resolv/res_hconf.c
- Authentication-results: sourceware.org; auth=none
- References: <5bfa6373-3817-4d31-a5ee-a8676e79b723 at BAMAIL02 dot ba dot imgtec dot org> <555BB55E dot 3050304 at cs dot ucla dot edu> <1432075989 dot 16668 dot 62 dot camel at ubuntu-sellcey> <555BC19B dot 90001 at cs dot ucla dot edu> <1432077972 dot 16668 dot 65 dot camel at ubuntu-sellcey> <20150519235817 dot 9516F2C3A73 at topped-with-meat dot com> <555C3E0B dot 2040404 at redhat dot com> <mvma8wzbqsv dot fsf at hawking dot suse dot de> <555C48F0 dot 2030208 at redhat dot com> <1432139240 dot 16668 dot 77 dot camel at ubuntu-sellcey> <55658C2A dot 70209 at redhat dot com> <5565B4D3 dot 3090401 at redhat dot com> <1432828842 dot 20199 dot 15 dot camel at ubuntu-sellcey> <20150528201038 dot 003B42C3B00 at topped-with-meat dot com> <1432850960 dot 20199 dot 25 dot camel at ubuntu-sellcey> <20150528225742 dot A6C552C3B00 at topped-with-meat dot com> <1432855124 dot 20199 dot 35 dot camel at ubuntu-sellcey> <20150528234359 dot 7530D2C3B00 at topped-with-meat dot com> <1432922021 dot 20199 dot 43 dot camel at ubuntu-sellcey>
> Is there a reason you want CUR_IFR in upper case? It is not that way in
> the code.
The convention for comments and log entries is to put local variable and
parameter names in upper case.