This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: git commit message conventions
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, libc-alpha at sourceware dot org
- Date: Wed, 03 Jun 2015 11:17:58 -0400
- Subject: Re: git commit message conventions
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1506022041430 dot 2704 at digraph dot polyomino dot org dot uk> <556E563C dot 1090204 at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1506031010550 dot 4266 at digraph dot polyomino dot org dot uk> <20150603150125 dot GB32684 at spoyarek dot pnq dot redhat dot com>
On 06/03/2015 11:01 AM, Siddhesh Poyarekar wrote:
> On Wed, Jun 03, 2015 at 10:14:19AM +0000, Joseph Myers wrote:
>> I propose that at this point we specifically do not adopt any further
>> conventions regarding how commit messages relate to ChangeLog entries
>
> However, I would love to see us progress to a stage where maintainers
> can simply do a git-am on the patch mbox and push the patch instead of
> manually patching, massaging the ChangeLog, massaging the NEWS file
> and then preparing the commit. The former will take care of most
> cases where a maintainer may forget to set --author when committing
> someone else's patch. I try to make sure I do it for all commits, but
> it's happened more than once that I realized that I hadn't set
> --author after I had pushed the patch.
>
> The part of NEWS that usually conflicts (the bug list) ought to be
> generated from bugzilla. I've said before that I don't find the
> ChangeLog format useful at all, but others have expressed their
> preference to keep it, so that IMO is the only blocker to us following
> the git-am workflow.
>
> Oh, and using the git-am workflow also allows us to automate patchwork
> so that we don't have to send reminders to clean up their patches
> there.
This is a distinct discussion, but yes we need to automate ChangeLog
generation from git commit messages and git notes (modified ChangeLog
entries), similarly with NEWS, that way it lives in the metadata and
is generated at release time or whenever a user wants it updated.
Cheers,
Carlos.