This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/14] [x86_64] Vector math functions (added vector cos tests)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 29 May 2015 13:30:11 +0000
- Subject: Re: [PATCH 2/14] [x86_64] Vector math functions (added vector cos tests)
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3uL-z3r0Q2aSpnPQnGLkj1_SDmj+h=WUr4MaaMaRGGftg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505221547070 dot 16611 at digraph dot polyomino dot org dot uk> <CAMXFM3vdR5gEkHwkdfmN0cpHH8_Vzk-XcnYJdMJZBrv_P+nOGQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505281726000 dot 16930 at digraph dot polyomino dot org dot uk> <CAMXFM3ufwtvGBZeCggWs0v0n1rk2+gHJtPOfwfXyoO7gNeNUJw at mail dot gmail dot com>
On Fri, 29 May 2015, Andrew Senkevich wrote:
> >> Is it possible to fold the following rules (now in math/Makefile)
> >> based on $(libm-vec-tests) or some other way? Else I need to move avx2
> >> related rules to sysdeps Makefile.
> >>
> >> $(objpfx)test-double-vlen2: $(libmvec) $(objpfx)init-arch.o \
> >> $(objpfx)test-double-vlen2-wrappers.o
> >>
> >> $(objpfx)test-double-vlen4: $(libmvec) $(objpfx)init-arch.o \
> >> $(objpfx)test-double-vlen4-wrappers.o
> >>
> >> $(objpfx)test-double-vlen4-avx2: $(libmvec) $(objpfx)init-arch.o \
> >> $(objpfx)test-double-vlen4-avx2-wrappers.o
> >>
> >> $(objpfx)test-double-vlen8: $(libmvec) $(objpfx)init-arch.o \
> >> $(objpfx)test-double-vlen8-wrappers.o
> >
> > I'd expect something like:
> >
> > $(addprefix $(objpfx),$(libm-vec-tests)): $(objpfx)%: $(libmvec) $(objpfx)init-arch.o $(objpfx)%-wrappers.o
> >
> > (untested) to work.
>
> Unfortunately it doesn`t work, looks like no dependencies from
> wrappers and init-arch to test and wrappers and init-arch are not
> compiled...
Well, you'll need to debug this; it's a routine use of static pattern
rules. Maybe there's some interaction with the other static pattern rules
in use? In any case, if it can't be made to work, the patch submission
should include a sufficient explanation of the relevant GNU make features
and why they can't handle this case.
--
Joseph S. Myers
joseph@codesourcery.com