This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/* v3] Generic string function optimization: Add skeleton
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Richard Henderson <rth at twiddle dot net>, libc-alpha at sourceware dot org
- Date: Fri, 29 May 2015 00:13:20 +0200
- Subject: Re: [PATCH 1/* v3] Generic string function optimization: Add skeleton
- Authentication-results: sourceware.org; auth=none
- References: <20150527060121 dot GA19105 at domone> <20150528142956 dot GA25176 at domone> <556754ED dot 70804 at twiddle dot net> <20150528180439 dot GB4872 at domone> <alpine dot DEB dot 2 dot 10 dot 1505282053130 dot 10508 at digraph dot polyomino dot org dot uk>
On Thu, May 28, 2015 at 08:54:31PM +0000, Joseph Myers wrote:
> On Thu, 28 May 2015, OndÅej BÃlka wrote:
>
> > Both comments are correct. We should do it generically and surround
> > these functions with ifdef to supply arch-specific versions.
>
> #if, not #ifdef, please, for all architecture choices in these functions.
> The sysdeps/generic version of the header architectures can use to change
> the default choices should have detailed comments on the default
> definitions of all the relevant macros to explain their semantics.
>
For what purpose? Its pointless except that you would need to have
additional header say precommon.h, then undef and redefine macro when
you want change.
And it doesn't help to catch any errors. If you misspell define then you
will get error with duplicate definition.