This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 5/6] vfprintf: Introduce printf_positional function
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 21 May 2015 10:06:12 -0400
- Subject: Re: [PATCH 5/6] vfprintf: Introduce printf_positional function
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1425246936 dot git dot fweimer at redhat dot com> <06448920c54ddf7d92cce8a2311a0daf470436aa dot 1425246936 dot git dot fweimer at redhat dot com> <54F9A453 dot 5060506 at redhat dot com> <555D53A1 dot 60604 at redhat dot com> <20150521041605 dot GL15498 at spoyarek dot pnq dot redhat dot com> <555D6537 dot 1090600 at redhat dot com> <555DE586 dot 40904 at redhat dot com>
On 05/21/2015 10:02 AM, Florian Weimer wrote:
> Again, the numbers are suspiciously good. But at least they do not show
> a performance regression.
Agreed. At least the benchmarks allow interested parties to
test roughly the same test on their hardware and complain if
it made it slower for them. The fact that sprintf got faster
is awesome, and isn't entirely far fetched given the cleanup.
> I'll commit the remaining vfprintf patches then.
Please do. Thanks.
Cheers,
Carlos.