This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Incomplete patch to fix build with top-of-tree GCC
- From: Roland McGrath <roland at hack dot frob dot com>
- To: <sellcey at imgtec dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 18 May 2015 15:00:44 -0700 (PDT)
- Subject: Re: Incomplete patch to fix build with top-of-tree GCC
- Authentication-results: sourceware.org; auth=none
- References: <1431708170 dot 16668 dot 8 dot camel at ubuntu-sellcey> <alpine dot DEB dot 2 dot 10 dot 1505151645070 dot 21212 at digraph dot polyomino dot org dot uk> <55565718 dot 6070107 at cs dot ucla dot edu> <5556C3E4 dot 1080108 at redhat dot com> <1431983665 dot 16668 dot 28 dot camel at ubuntu-sellcey>
> - struct sockaddr_storage ss;
> + union {
> + struct sockaddr generic;
> + struct sockaddr_in in;
> + struct sockaddr_in6 in6;
> + } ss;
Since we're not reformatting this file to GNU style (which would put the {
here on its own line), this should instead stick with the existing (BSD)
style of the rest of the file, which is TAB indentation. (These lines
appear twice in the patch. Fix both places.)
With that formatting fix, this looks fine to me.