This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
PING [COMMITTED PATCH] BZ#18383: Add test case for large alignment in TLS blocks.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 12 May 2015 14:32:03 -0700
- Subject: PING [COMMITTED PATCH] BZ#18383: Add test case for large alignment in TLS blocks.
- Authentication-results: sourceware.org; auth=none
On Thu, May 7, 2015 at 3:30 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, May 7, 2015 at 2:10 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> The log entry needs the BZ# marker.
>>
>> I'm having a hard time finding the calculation in the dynamic-linking case
>> that corresponds to this piece of __libc_setup_tls. Since there are two
>> places where the logic should match, we really should make it much more
>> clear how they relate. If there isn't any obvious refactoring that would
>> share more of this logic between the two cases, can you at least add a
>> comment in __libc_setup_tls that points to the implementation of the
>> matching logic in the dynamic-linking case?
>>
>
> Here is the updated patch.
>
>
> --
> H.J.
> --
> We need to align TCB offset to the maximum alignment for TLS_TCB_AT_TP
> targets, similar to what _dl_allocate_tls_storage in elf/dl-tls.c does.
>
> [BZ #18383]
> * csu/libc-tls.c (__libc_setup_tls): Align TCB offset to the
> maximum alignment for TLS_TCB_AT_TP targets.
Ping.
--
H.J.