Re: [PATCH][BZ 14172] Add South Azerbaijani (azb) locale

[Marko Myllynen <myllynen at redhat dot com>]

Hi,

looks pretty good to me. Again, I can't comment on the language itself
but if it now compiles then at least the basics should be ok.

Thanks,

On 2015-05-08 03:00, Mjbmr wrote:
> Sorry, I think I missed a thing.
> 
> On 5/8/2015 3:55 AM, Mjbmr wrote:
>> Hi,
>>
>> Thank you for your feedback, new patch attached.
>>
>> On 5/7/2015 12:54 PM, Marko Myllynen wrote:
>>> Hi,
>>>
>>> On 2015-05-07 07:55, Mjbmr wrote:
>>>> Add South Azerbaijani (azb) locale
>>>>
>>>> https://sourceware.org/bugzilla/show_bug.cgi?id=14172#c11
>>>> https://www.ethnologue.com/language/azb
>>> I don't know the language so I cannot comment on those aspects but in
>>> general it looks pretty good with one major and few minor issues. The
>>> major issue is that the locale does not compile, please see the Locales
>>> wiki page for instructions how to test locales (looks like you need to
>>> adjust the country codes and perhaps also introduce a new language code
>>> definition in iso-639.def):
>>>
>>> https://sourceware.org/glibc/wiki/Locales
>>>
>>> Also see the manual page or other locales (like de_DE) for the format to
>>> use (ie, plain strings / texts are very rarely used):
>>>
>>> http://man7.org/linux/man-pages/man5/locale.5.html
>>>
>>> Please add the week definition to LC_TIME section and fix the fr_IR
>>> typo.
>>>
>>> Cheers,
>>>
>>
> 


-- 
Marko Myllynen