This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ 14172] Add South Azerbaijani (azb) locale


Sorry, I think I missed a thing.

On 5/8/2015 3:55 AM, Mjbmr wrote:
Hi,

Thank you for your feedback, new patch attached.

On 5/7/2015 12:54 PM, Marko Myllynen wrote:
Hi,

On 2015-05-07 07:55, Mjbmr wrote:
Add South Azerbaijani (azb) locale

https://sourceware.org/bugzilla/show_bug.cgi?id=14172#c11
https://www.ethnologue.com/language/azb
I don't know the language so I cannot comment on those aspects but in
general it looks pretty good with one major and few minor issues. The
major issue is that the locale does not compile, please see the Locales
wiki page for instructions how to test locales (looks like you need to
adjust the country codes and perhaps also introduce a new language code
definition in iso-639.def):

https://sourceware.org/glibc/wiki/Locales

Also see the manual page or other locales (like de_DE) for the format to
use (ie, plain strings / texts are very rarely used):

http://man7.org/linux/man-pages/man5/locale.5.html

Please add the week definition to LC_TIME section and fix the fr_IR typo.

Cheers,



Attachment: patch0003.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]