This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: pragma change breaks build
- From: David Miller <davem at davemloft dot net>
- To: eggert at cs dot ucla dot edu
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 27 Apr 2015 22:45:33 -0400 (EDT)
- Subject: Re: pragma change breaks build
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1504271712090 dot 17788 at digraph dot polyomino dot org dot uk> <20150427 dot 132700 dot 355837165424266128 dot davem at davemloft dot net> <553EBBA8 dot 6050902 at cs dot ucla dot edu>
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 27 Apr 2015 15:43:52 -0700
> David Miller wrote:
>> instead of just adding a "= 0" initializer to vallen so
>> that all gcc's will not warn
>
> That could cause glibc to have a useless machine instruction, no?
> Horrors!
Good you thought about that since setenv() is a performance critical
library routine...
> Does the attached patch work for you?
I'll give this a test later, thanks.