This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Do not build with -Winline
- From: Florian Weimer <fweimer at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 24 Apr 2015 11:11:26 +0200
- Subject: [PATCH] Do not build with -Winline
- Authentication-results: sourceware.org; auth=none
Per the previous discussion.
--
Florian Weimer / Red Hat Product Security
>From 69372f19d39ac6cf3570cbf62ae4610a26c15e41 Mon Sep 17 00:00:00 2001
From: Florian Weimer <fweimer@redhat.com>
Date: Fri, 24 Apr 2015 11:10:24 +0200
Subject: [PATCH] Do not build with -Winline
-Winline causes architecture- and optimization-dependent build failures
due to -Werror. -Winline warns about inlining decisions based on
branch hints, in effect preventing the use of inline functions in
header files (because they might be called on unlikely branches, leading
to a decision not to inline).
The option was apparently added to the glibc build at a time when GCC
did not support the always_inline attribute. With current GCC versions,
inlining failure for functions declared always_inline will receive a
warning under -Wattributes, which is enabled by default, so -Winline
appears unnecessary.
---
ChangeLog | 4 ++++
Makeconfig | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2c01eac..ace5fb3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2015-04-24 Florian Weimer <fweimer@redhat.com>
+
+ * Makeconfig (+gccwarn): Remove -Winline.
+
2015-04-22 Wilco Dijkstra <wdijkstr@arm.com>
* math/k_casinh.c (__kernel_casinh): Use __copysign.
diff --git a/Makeconfig b/Makeconfig
index dc7f208..77752c0 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -739,9 +739,9 @@ endif
# Extra flags to pass to GCC.
ifeq ($(all-warnings),yes)
-+gccwarn := -Wall -Wwrite-strings -Winline -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar
++gccwarn := -Wall -Wwrite-strings -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar
else
-+gccwarn := -Wall -Wwrite-strings -Winline
++gccwarn := -Wall -Wwrite-strings
endif
+gccwarn += -Wundef
ifeq ($(enable-werror),yes)
--
2.1.0