This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/3] Consolidate gettimeofday across aarch64/s390/tile
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Nathan Lynch <Nathan_Lynch at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 22 Apr 2015 15:40:57 -0300
- Subject: Re: [PATCH v2 2/3] Consolidate gettimeofday across aarch64/s390/tile
- Authentication-results: sourceware.org; auth=none
- References: <55352DCB dot 4020807 at linaro dot org> <5537CB3D dot 9090300 at codesourcery dot com>
Hi
On 22-04-2015 13:24, Nathan Lynch wrote:
> On 04/20/2015 11:48 AM, Adhemerval Zanella wrote:
>> This patch removes the architecture specific gettimeofday implementation
>> to use the vDSO symbol and consolidate it on a common Linux one.
>> Similat to gettime and getres vDSO implementation, each arch that supports
>> gettimeofday through vDSO should just implement INLINE_VSYSCALL to access
>> the symbol and define HAVE_GETTIMEOFDAY_VSYSCAL as 1.
>>
>> --
>>
>> * sysdeps/unix/sysv/linux/aarch64/gettimeofday.c: Remove file.
>> * sysdeps/unix/sysv/linux/s390/gettimeofday.c: Likewise.
>> * sysdeps/unix/sysv/linux/tile/gettimeofday.c: Likewise.
>> * sysdeps/unix/sysv/linux/aarch64/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCAL]: Define.
>> * sysdeps/unix/sysv/linux/s390/s390-32/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCAL]: Likewise.
>> * sysdeps/unix/sysv/linux/s390/s390-64/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCAL]: Likewise.
>> * sysdeps/unix/sysv/linux/tile/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCAL]: Likewise.
>
> Please make the spelling of HAVE_GETTIMEOFDAY_VSYSCALL in the patch
> description and Changelog match its spelling in the code... :)
>
>
Ouch and thanks, I will fix it.