This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] Define INLINE_VSYSCALL on all ports
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 20 Apr 2015 09:56:18 -0300
- Subject: Re: [PATCH 1/4] Define INLINE_VSYSCALL on all ports
- Authentication-results: sourceware.org; auth=none
- References: <552EC85A dot 8060505 at linaro dot org> <20150415222654 dot DB2A72C3BC9 at topped-with-meat dot com>
Hi
On 15-04-2015 19:26, Roland McGrath wrote:
>> * sysdeps/unix/sysv/linux/alpha/sysdep.h [INLINE_VSYSCALL]: Define
>> INLINE_SYSCALL.
>
> The [foo] syntax corresponds to an '#if foo' block. The (foo) syntax is
> what you use when foo is what you touched, whether it's a function,
> variable, macro, type, or whatever. A coherent entry for what the change
> actually does would be:
>
> * sysdeps/unix/sysv/linux/alpha/sysdep.h (INLINE_VSYSCALL):
> New macro; just use INLINE_SYSCALL.
Right, I will change it.
>
> But repeating boilerplate like this across a lot of sysdeps files is
> usually a sign that you're doing it wrong. Why not instead have some
> common place that does:
>
> #ifndef INLINE_VSYSCALL
> # define INLINE_VSYSCALL INLINE_SYSCALL
> #endif
>
> ?
>
That is my idea of a subsequent patch, however seems that a more
comprehensible refactor will be better. I am withdrawing this patch
and I will send another one soon.