This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Build problem with ToT GCC
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 17 Apr 2015 12:51:52 -0700
- Subject: Re: Build problem with ToT GCC
- Authentication-results: sourceware.org; auth=none
- References: <88baa580-c27b-4fc8-b7da-7de3c0a7f64d at BAMAIL02 dot ba dot imgtec dot org> <20150417192032 dot 70DE42C3B91 at topped-with-meat dot com>
- Reply-to: <sellcey at imgtec dot com>
On Fri, 2015-04-17 at 12:20 -0700, Roland McGrath wrote:
> Can you try this change (on branch roland/dl-nns) with that compiler?
> I suspect a compile-time constant preventing evaluation of the
> expressions doing indexing will avoid the warning. If it doesn't,
> then the right thing to do is to put that inside #if DL_NNS > 1.
>
> While I was there I noticed that it's not properly checking for wildly
> bogus NSID values that would make that indexing bogus at runtime (in
> the SHARED case), so I put that in too.
>
>
> Thanks,
> Roland
>
>
> 2015-04-17 Roland McGrath <roland@hack.frob.com>
>
> * elf/dl-open.c (_dl_open): Use __glibc_unlikely in invalid namespace
> check. Reject NSID < 0 and NSID >= dl_nns, and check for DL_NNS==1,
> before using NSID as an index.
This patch did fix the problem in dl-open.c but dl-close.c has the same
issue and would need the same fix.
Steve Ellcey
sellcey@imgtec.com