This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use correct signedness in wcsncmp.


On Tue, Apr 07, 2015 at 04:59:38PM +0200, Stefan Liebler wrote:
> 2015-04-07  Stefan Liebler  <stli@linux.vnet.ibm.com>
> 
> 	* wcsmbs/wcsncmp.c (wcsncmp): Compare as wchar_t, not wint_t.
> 	  Use signed comparision instead of substraction to avoid
> 	  overflow bug.
> 	* localedata/tests-mbwc/tst_wcsncmp.c (tst_wcsncmp):
> 	  Take the sign of ret.
> 	* localedata/tests-mbwc/dat_wcsncmp.c (tst_wcsncmp_loc):
> 	  Do not expect precise return values. Only the sign matters.
> 	* wcsmbs/Makefile (strop-tests): Add wcsncmp.
> 	* wcsmbs/test-wcsncmp.c: New File.
> 	* string/test-strncmp.c: Add wcsncmp support.

Applied. Thanks!

-Andreas-


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]