This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2)
- From: Gerald Pfeifer <gerald at pfeifer dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jason Merrill <jason at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Manuel López-Ibáñez <lopezibanez at gmail dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>, Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Sun, 12 Apr 2015 21:30:02 +0200 (CEST)
- Subject: Re: [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2)
- Authentication-results: sourceware.org; auth=none
- References: <CAESRpQDeicuneH9VGgCEhUNz3Kfn3EAJa+JO64iqLoHH9xgbpA at mail dot gmail dot com> <53BDB402 dot 20309 at redhat dot com> <20140710125222 dot GI31640 at tucnak dot redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1407110129070 dot 6423 at tuna dot site> <20140711201852 dot GD31640 at tucnak dot redhat dot com>
Hi Jakub,
On Fri, 11 Jul 2014, Jakub Jelinek wrote:
> So like this? Also have fixed one omitted line in c-parser.c,
> this patch bootstrapped/regtested fine:
just in time for GCC 5.1 RC1 :-) a small update on top of yours.
Committed.
Gerald
2015-04-12 Gerald Pfeifer <gerald@pfeifer.com>
* doc/invoke.texi (-Wmemset-transposed-args): Break a long
sentence. Improve grammar.
Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi (revision 222021)
+++ doc/invoke.texi (working copy)
@@ -4909,10 +4909,10 @@
second argument is not zero and the third argument is zero. This warns e.g.@
about @code{memset (buf, sizeof buf, 0)} where most probably
@code{memset (buf, 0, sizeof buf)} was meant instead. The diagnostics
-is only emitted if the third argument is literal zero, if it is some expression
-that is folded to zero, or e.g. a cast of zero to some type etc., it
-is far less likely that user has mistakenly exchanged the arguments and
-no warning is emitted. This warning is enabled by @option{-Wall}.
+is only emitted if the third argument is literal zero. If it is some
+expression that is folded to zero, a cast of zero to some type, etc.,
+it is far less likely that the user has mistakenly exchanged the arguments
+and no warning is emitted. This warning is enabled by @option{-Wall}.
@item -Waddress
@opindex Waddress