This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 27 Mar 2015 14:39, Shawn Landden wrote: > +/* Process the remaining bytes in the internal buffer and the usual > + prolog according to the standard and write the result to RESBUF. */ two spaces after the period. please check the whole patch. > +void * > +__sha224_finish_ctx (sha256_ctx *ctx, void *resbuf) > +{ > + __sha256_finish_ctx_generic (ctx); > > -void > -__sha256_process_bytes (buffer, len, ctx) > + /* Put result from CTX in first 28 bytes following RESBUF. */ > + for (unsigned int i = 0; i < 7; ++i) > + put_be32 (((uint32_t *) resbuf) + i, ctx->H[i]); erm, looks to me like resbuf is no longer void* ... > +extern void *__sha256(const void *__restrict d, size_t n, void *__restrict md) { incorrect style: no extern, and the brace goes on a sep line -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |