This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] add benchmark for strcoll


+static int
+bench_file_list (json_ctx_t *json_ctx, const char *dirname, const char *locale)

If you just create a file with this information once, you can collapse
this special case into the other cases and get rid of this function.


This implies that the file list outdates over time. Is this ok?

diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
index 4156f9e..2a48a34 100644
--- a/localedata/gen-locale.sh
+++ b/localedata/gen-locale.sh
@@ -30,7 +30,8 @@ generate_locale ()
     charmap=$1
     input=$2
     out=$3
-  if ${localedef_before_env} ${run_program_env} I18NPATH=. \
+  if ${localedef_before_env} ${run_program_env} \
+     I18NPATH=${common_objpfx}../localedata \

Shouldn't this be I18NPATH=${common_objpfx}localedata?


I18NPATH has to point to glibc/localedata and common_objpfx points to the build directory. So I18NPATH=${common_objpfx}localedata should not work.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]