Re: [PATCH] elf.h SHF_EXCLUDE signed int 31 bit shift triggers undefined behaviour.

[Mike Frysinger <vapier at gentoo dot org>]

On 24 Mar 2015 20:53, Florian Weimer wrote:
> * Mike Frysinger:
> > On 24 Mar 2015 14:13, Szabolcs Nagy wrote:
> >> On 24/03/15 10:39, Mark Wielaard wrote:
> >> > Any use of SHF_EXCLUDE in code that tries to check it against sh_flags
> >> > will trigger undefined behaviour because it is defined as a 31 bit shift
> >> > against an signed integer. Fix by explicitly using an unsigned int.
> >> 
> >> there is another proposed patch for this
> >> 
> >> https://sourceware.org/ml/libc-alpha/2015-03/msg00287.html
> >> 
> >> >  ChangeLog | 4 ++++
> >> >  elf/elf.h | 2 +-
> >> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >> 
> >> i think changelog entries are supposed to be submitted separately
> >
> > nope ... should be same commit
> 
> There used be an expectation that the ChangeLog update was not to be
> submitted as part of the patch, but as a separate item in the patch
> submission (not as a diff hunk, not with + prefix).
> 
> Has this changed?  It would certainly make things simpler for me. :)

i don't know what the preference is, but i don't mind either
-mike

Attachment: signature.asc
Description: Digital signature