This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca


On 03/16/2015 05:51 PM, Mike Frysinger wrote:
> On 16 Mar 2015 15:29, Florian Weimer wrote:
>> +  for (psize = 128; ; psize *= 2) +    { +      char
>> buf[psize]; +      INTERNAL_SYSCALL_DECL (err);
> 
> style says there should be a blank line here -- after the decls and
> before the first line of code (the res assignment).  otherwise,
> this does look better than v1.  thanks!

Thanks, I've committed it after adding the blank line.

Could you have a look at the sister patch as well?  Thanks.

<https://sourceware.org/ml/libc-alpha/2015-03/msg00544.html>

-- 
Florian Weimer / Red Hat Product Security


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]