This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
- From: Florian Weimer <fweimer at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Mon, 23 Mar 2015 16:42:58 +0100
- Subject: Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1425285061 dot git dot fweimer at redhat dot com> <080236bd5f23d9be4c47794ad23e96d52d380f5d dot 1425285061 dot git dot fweimer at redhat dot com> <20150302195844 dot GA24238 at vapier> <5506E8E6 dot 1000906 at redhat dot com> <20150316165132 dot GE877 at vapier>
On 03/16/2015 05:51 PM, Mike Frysinger wrote:
> On 16 Mar 2015 15:29, Florian Weimer wrote:
>> + for (psize = 128; ; psize *= 2) + { + char
>> buf[psize]; + INTERNAL_SYSCALL_DECL (err);
>
> style says there should be a blank line here -- after the decls and
> before the first line of code (the res assignment). otherwise,
> this does look better than v1. thanks!
Thanks, I've committed it after adding the blank line.
Could you have a look at the sister patch as well? Thanks.
<https://sourceware.org/ml/libc-alpha/2015-03/msg00544.html>
--
Florian Weimer / Red Hat Product Security