This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][aarch64] Fix the big endian loader name


On 03/06/2015 11:47 AM, Marcus Shawcroft wrote:
> On 6 March 2015 at 16:24, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 03/06/2015 05:48 AM, Szabolcs Nagy wrote:
>>> AArch64 uses arch specific configure.ac fragment to set HAVE_AARCH64_BE
>>> in config.h so later the loader name can be decided based on this macro.
>>>
>>> However config.h.in needs an appropriate line to generate the macro.
>>>
>>> I think the loader name should be managed in a simpler way for future
>>> abi variants.
>>>
>>> Changelog:
>>>
>>> 2015-03-06  Szabolcs Nagy  <szabolcs.nagy@arm.com>
>>>
>>>       * config.h.in (HAVE_AARCH64_BE): Add.
>>>
>>
>> Since you are talking about the "long term", what you propose is
>> not what we want.
>>
>> Roland, please correct me if I'm wrong, but I think the consensus
>> was that all machine-dependent macros should move out of the top-level
>> config.h.in, and into the machine directories.
>>
>> Unfortunately that requires work and rejiggering and we just keep
>> putting the machine macros into the top-level config.h.in.
> 
> Looks to me that this change is need to make the existing configure.ac
> work as intended.  I would have thought it is better to separate such
> fixes from restructure work.

It is. Sorry, let me be clear, the patch as posted is fine
if it is required for AArch64.

I was simply talking about "future" things and explaining
how we wish this worked.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]