This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Support HWCAPs for MIPS
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>, Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 06 Mar 2015 10:57:27 -0500
- Subject: Re: [PATCH] Support HWCAPs for MIPS
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B0235320F271C0 at LEMAIL01 dot le dot imgtec dot org> <20150306113811 dot GA12857 at vapier> <87h9tynmx7 dot fsf at igel dot home>
On 03/06/2015 10:52 AM, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
>
>>> +{
>>> + int i;
>>> +
>>> + /* Fallback to unknown output mechanism. */
>>> + if (type == AT_HWCAP2)
>>> + return -1;
>>> +
>>> + _dl_printf ("AT_HWCAP: ");
>>> +
>>> + for (i = 0; i < _DL_HWCAP_COUNT; ++i)
>>> + if (word & (1 << i))
>>
>> i is an int, but word is an unsigned long int.
>
> That's not a problem. The problem is that 1 is an int.
Right, you want 1U.
Which reminds me that elf.h is all wrong also and needs 1U everywhere.
Cheers,
Carlos.