This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/6] vfprintf: Introduce THOUSANDS_SEP_T
- From: Florian Weimer <fweimer at redhat dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>, libc-alpha at sourceware dot org
- Date: Tue, 03 Mar 2015 08:36:35 +0100
- Subject: Re: [PATCH 1/6] vfprintf: Introduce THOUSANDS_SEP_T
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1425246936 dot git dot fweimer at redhat dot com> <c3bb2064d9b6b4cfe0102b2b4af595da01153cbe dot 1425246936 dot git dot fweimer at redhat dot com> <54F5156C dot 5030906 at cs dot ucla dot edu>
On 03/03/2015 02:59 AM, Paul Eggert wrote:
> Florian Weimer wrote:
>> # define INT_T int
>> +typedef const char *THOUSANDS_SEP_T;
>
> A nit: if the name's not a macro, I'd keep it lower-case. Upper-case is
> for shouting "WATCH OUT! I LOOK LIKE A NORMAL NAME, BUT I ACTUALLY AM A
> MACRO!"
In this case, I was more going for âcareful, this depends on whether you
are in the wide variant or notâ (like CHAR_T). I agree with you that we
should avoid the preprocessor if possible, so I used a typedef.
--
Florian Weimer / Red Hat Product Security