This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 02 Mar 2015 10:40:46 +0100
- Subject: Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1425285061 dot git dot fweimer at redhat dot com> <7a6fe503fb764beee3d5b89662d3bbf65242161c dot 1425285061 dot git dot fweimer at redhat dot com> <mvm7fuzwxmg dot fsf at hawking dot suse dot de>
On 03/02/2015 10:35 AM, Andreas Schwab wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>
>> +#pragma once
>
> Don't use pragma once.
Why? The GCC implementation was fixed ages ago, and it's not an
installed header file.
>> + GLIBC_2.22 {
>> + __libc_scratch_buffer_grow;
>> + __libc_scratch_buffer_grow_preserve;
>> + __libc_scratch_buffer_set_array_size;
>
> Are they supposed to be used outside of glibc? Since scratch_buffer.h
> isn't installed, it doesn't look like.
See the commit message. nscd and some of the NSS modules need these
symbols.
--
Florian Weimer / Red Hat Product Security