This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix sysdeps/unix/sysv/linux/arm/libc-do-syscall.S warning

From: Mike Frysinger <vapier at gentoo dot org>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Sun, 1 Mar 2015 23:14:14 -0500
Subject: Re: Fix sysdeps/unix/sysv/linux/arm/libc-do-syscall.S warning
Authentication-results: sourceware.org; auth=none
References: <alpine dot DEB dot 2 dot 10 dot 1411261513490 dot 27454 at digraph dot polyomino dot org dot uk>

On 26 Nov 2014 15:14, Joseph Myers wrote:
> This patch fixes a warning
> 
> ../include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
> 
> seen when building for ARM.  This warning comes from libc-do-syscall.S
> being built for nscd: the nscd build uses _FORTIFY_SOURCE, while .S
> files aren't built with -O, and the combination produces a warning.
> As _FORTIFY_SOURCE doesn't do anything for .S files, undefining it in
> libc-do-syscall.S seems the simplest solution.

should we update features.h to avoid that define when __ASSEMBLER__ is defined ?
seems like this warning can impact external code too.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: Fix sysdeps/unix/sysv/linux/arm/libc-do-syscall.S warning
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]