This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] hppa: fix __O_SYNC to match the kernel


On Sun, 1 Mar 2015, John David Anglin wrote:

> The main bug in feholdexcept is the second set of bufptr.  This existed 
> to the restore the exception registers in reverse order.  This statement 
> should have been removed when the code was changed to only update the 
> status and first exception registers.  The offset used in the statement 
> is also off by a factor two, so it probably never worked correctly.  
> With the current patch, the code loads zero to the status and exception 
> register.  As a result, the T bit is not set properly.

If this bug was user-visible in a release, there should be a bug filed in 
Bugzilla for it (this generally applies when fixing any bug that was 
user-visible in a release).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]