This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Paul Pluzhnikov <ppluzhnikov at gmail dot com>
- Cc: Florian Weimer <fw at deneb dot enyo dot de>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Mon, 23 Feb 2015 16:33:05 +0000
- Subject: Re: [patch] Fix BZ #17916 fopen unbounded stack usage for ccs= modes
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobPBCpZwMyF5F_4XzNJKKi64xMGtWgBXO_iDU_HpZ6+V9g at mail dot gmail dot com> <874mqdbr1w dot fsf at mid dot deneb dot enyo dot de> <CALoOobMKYAvdj63=7JKyQTPZHx_6c_0RVTxXjcLk-_wyFYWryg at mail dot gmail dot com>
On Sun, 22 Feb 2015, Paul Pluzhnikov wrote:
> On Sun, Feb 22, 2015 at 12:59 PM, Florian Weimer <fw@deneb.enyo.de> wrote:
>
> Thanks for the review.
>
> >> Attached patch fixes BZ #17916 fopen unbounded stack usage for ccs= modes
> >> Tested on Linux/x86_64, no failures.
> >
> > This should have a test case.
>
> I am not sure how to test for unbounded stack use.
Typically such tests use setrlimit to set a stack limit lower than the
amount of stack space the code used before the fix.
--
Joseph S. Myers
joseph@codesourcery.com