This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix MIPS build failure caused by -Werror=undef
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at imgtec dot com>
- Cc: "Maciej W. Rozycki" <macro at linux-mips dot org>, <libc-alpha at sourceware dot org>
- Date: Tue, 17 Feb 2015 18:11:36 +0000
- Subject: Re: [Patch] Fix MIPS build failure caused by -Werror=undef
- Authentication-results: sourceware.org; auth=none
- References: <04dee4c5-a06d-447e-8174-ab39f52a4b48 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot LFD dot 2 dot 11 dot 1502140537270 dot 11294 at eddie dot linux-mips dot org> <1424196067 dot 27855 dot 80 dot camel at ubuntu-sellcey>
On Tue, 17 Feb 2015, Steve Ellcey wrote:
> You are right. Apparently, this header is not actually used in the
> glibc build since it didn't cause a build failure but we should fix it
There are both sysdeps/mips/bits/endian.h (not used by any current
configuration) and sysdeps/unix/sysv/linux/mips/bits/endian.h - clearly
not both needed since one bits/endian.h file could be generic. They
should be unified. (I'd say prefer sysdeps/mips/bits/endian.h as
symmetric between the endiannesses, but with the comment corrected as
"This file is for a machine using big-endian mode." is simply wrong.)
--
Joseph S. Myers
joseph@codesourcery.com