This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Adjust some timeouts for slow CPUs
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Chung-Lin Tang <cltang at codesourcery dot com>, libc-alpha at sourceware dot org
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Tue, 03 Feb 2015 13:33:11 -0500
- Subject: Re: [PATCH] Adjust some timeouts for slow CPUs
- Authentication-results: sourceware.org; auth=none
- References: <54C3376D dot 80100 at codesourcery dot com> <54D0264E dot 1080804 at codesourcery dot com>
On 02/02/2015 08:37 PM, Chung-Lin Tang wrote:
> Ping?
>
> On 2015/1/24 02:10 PM, Chung-Lin Tang wrote:
>> Hi, this was submitted earlier with the nios2 patches, but Joseph
>> suggested it to be a separate patch.
>>
>> Some tests take a really long time to run on slow CPUs, often with no
>> FPU, like typical Nios II soft-cores; I noticed a few tests started to
>> timeout after they were updated to use test-skeleton.c.
>>
>> So I'm seeking permission to adjust the timeouts as attached. This
>> won't unstabilize anything, okay to commit?
>>
>> Thanks,
>> Chung-Lin
>>
>> 2015-01-24 Chung-Lin Tang <cltang@codesourcery.com>
>>
>> * libio/tst-memstream2.c (TIMEOUT): Define as 100.
>> * math/atest-exp.c (TIMEOUT): Adjust to 200.
>> * math/atest-exp2.c (TIMEOUT): Adjust to 300.
>> * math/atest-sincos.c (TIMEOUT): Adjust to 600.
>>
>
OK, for 2.22 when it opens.
All of our tests should work consistently for all of our supported
machines, and now that Nios II is checked in, this patch has a reason
to exist.
I'm sure you know, but just to reiterate, you could use TIMEOUTFACTOR
env-var to work around this, but it's always good to make this work
out of the box.
Cheers,
Carlos.