This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.21 - Machine maintainers, please test your machines.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Torvald Riegel <triegel at redhat dot com>, Chris Metcalf <cmetcalf at ezchip dot com>, "Carlos O'Donell" <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, David Miller <davem at davemloft dot net>, Richard Henderson <rth at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, Thomas Schwinge <thomas at codesourcery dot com>, Marcus Shawcroft <marcus dot shawcroft at linaro dot org>, Chung-Lin Tang <chunglin_tang at mentor dot com>, Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Date: Mon, 26 Jan 2015 08:21:40 -0800
- Subject: Re: glibc 2.21 - Machine maintainers, please test your machines.
- Authentication-results: sourceware.org; auth=none
- References: <54C2BDD7 dot 7000304 at redhat dot com> <54C3B6D5 dot 3090308 at ezchip dot com> <1422119595 dot 29655 dot 42 dot camel at triegel dot csb> <54C5094A dot 8060300 at ezchip dot com> <54C51D94 dot 6030007 at ezchip dot com> <CAMe9rOpOuuC_Bf1eHs9iaiUY6V-fVMHUCKZPAwje_NemBy84wA at mail dot gmail dot com> <20150125215150 dot GA15033 at gmail dot com> <54C569E5 dot 9050305 at ezchip dot com> <CAMe9rOrundPWENuw-Ne=pW6706Rc9RLpkw7Zx859M9G1JRFk0A at mail dot gmail dot com> <mvmd261rj1p dot fsf at hawking dot suse dot de> <CAMe9rOotZWCHsp4Wizrk4_i+-CWVVxjrRy9n_9_sF7yuW9TyiQ at mail dot gmail dot com> <mvmlhkpps9f dot fsf at hawking dot suse dot de> <CAMe9rOoKMiLm1sUmQYFEkkO=SRTPqZkmHuBh7_4jLqFADTcZbA at mail dot gmail dot com> <mvmd261ppcx dot fsf at hawking dot suse dot de> <CAMe9rOrn_D7pzsp2bJ_soLLGBqO20bPvy=ys+rhnfaaR1ERPHg at mail dot gmail dot com> <mvm8ugppork dot fsf at hawking dot suse dot de> <1422286429 dot 29655 dot 120 dot camel at triegel dot csb> <mvmvbjto7y8 dot fsf at hawking dot suse dot de> <1422288868 dot 29655 dot 125 dot camel at triegel dot csb> <mvmr3uho6q8 dot fsf at hawking dot suse dot de>
On Mon, Jan 26, 2015 at 8:18 AM, Andreas Schwab <schwab@suse.de> wrote:
> Torvald Riegel <triegel@redhat.com> writes:
>
>> I agree we change the ABI. Just to clarify though, your concern is thus
>> specifically due to ABI changes of sem_t and what they would do in user
>> programs (e.g., if a sem_t is part of another struct whose alignment
>> changes in return) -- and not regarding how glibc code could fail if
>> presented with a non-8B-aligned sem_t?
>
> Both can fail. Just because it doesn't fail today doesn't mean it won't
> bite you in the future.
>
The problem is
struct foo
{
int foo;
semt_t sem;
int bar;
}
sem/bar have different offsets and struct foo has different sizes when
alignment of sem_t is is changed. I withdrew my change to sem_t.
--
H.J.
- References:
- glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.
- Re: glibc 2.21 - Machine maintainers, please test your machines.