This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Fix inline feraiseexcept, feclearexcept macros
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Sat, 24 Jan 2015 02:21:11 +0000
- Subject: Re: [PATCH] powerpc: Fix inline feraiseexcept, feclearexcept macros
- Authentication-results: sourceware.org; auth=none
- References: <54C2C558 dot 2050304 at linux dot vnet dot ibm dot com>
On Fri, 23 Jan 2015, Adhemerval Zanella wrote:
> This patch fixes the inline feraiseexcept and feclearexcept macros for
> powerpc by casting the input argument to integer before operation on it.
>
> It fixes BZ#17776.
This should add an (architecture-independent) testcase (probably covering
such arguments to all <fenv.h> functions that accept an integer argument,
not just those with the bug).
> + if (__builtin_constant_p (__e) \
Have you made sure __builtin_constant_p works for variables assigned like
this from a macro argument?
--
Joseph S. Myers
joseph@codesourcery.com