This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] s390: Use generic lowlevellock-futex.h.
- From: Torvald Riegel <triegel at redhat dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Wed, 07 Jan 2015 16:44:15 +0100
- Subject: Re: [PATCH] s390: Use generic lowlevellock-futex.h.
- Authentication-results: sourceware.org; auth=none
- References: <1418857172 dot 20194 dot 24 dot camel at triegel dot csb>
Ping.
On Wed, 2014-12-17 at 23:59 +0100, Torvald Riegel wrote:
> This untested patch removes the custom futex operations in s390
> lowlevellock.h, and instead uses the generic ones from
> lowlevellock-futex.h. They seem to be equivalent.
> It also removes the definition of SYS_futex because it doesn't seem to
> be used anywhere else.
>
> It would be even nicer if we could remove the custom lowlevellock.h
> altogether. However, current s390 has custom asm for the lock fast
> paths, so this needs a closer review than I can do. Could you check
> whether that would be possible?
>
> Alternatively, I'd at least like to use generic futex operations. Could
> you please review and test? Thanks!
>
>
> 2014-12-17 Torvald Riegel <triegel@redhat.com>
>
> * sysdeps/unix/sysv/linux/s390/lowlevellock.h: Include
> <lowlevellock-futex.h> and remove macros and functions that are now
> defined there.
> (SYS_futex): Remove.
>