This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCHv4, MIPS] Add support for O32 FPXX and program header based ABI information
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: "'libc-alpha at sourceware dot org'" <libc-alpha at sourceware dot org>, "Moore, Catherine (Catherine_Moore at mentor dot com)" <Catherine_Moore at mentor dot com>, 'Andrew Pinski' <pinskia at gmail dot com>, "Rich Felker (dalias at libc dot org)" <dalias at libc dot org>, Rich Fuhler <Rich dot Fuhler at imgtec dot com>, "'macro at codesourcery dot com'" <macro at codesourcery dot com>
- Date: Wed, 31 Dec 2014 17:23:59 +0000
- Subject: RE: [PATCHv4, MIPS] Add support for O32 FPXX and program header based ABI information
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B0235320F8DFA4 at LEMAIL01 dot le dot imgtec dot org>
On Tue, 23 Dec 2014, Matthew Fortune wrote:
> I'm still running the glibc testsuite on a native MIPS machine to double
> check results. I'm running with glibc configured for mips2/mips3 on a
> board with no-fpu and see 31 failures for O32, 32 for N64 and a bizarre
> set of failures about "allocate_stack: Assertion `size != 0' failed."
> for N32. None of these look anything to do with this patch so I'm collecting
> reference results before my patch to make sure.
That's more than the known set for previous releases listed at
<https://sourceware.org/glibc/wiki/Release/2.20>, but still should be
independent of this patch.
> Any further feedback welcome... Assuming tests do turn out with the same PASS
> rate then I'd like to commit?
OK with changes as noted below:
> +#if __mips_fpr != 0 || _MIPS_SPFPSET != 16
> +#error This test requires -mfpxx -mno-odd-spreg
> +#endif
Missing preprocessor indentation, "# error". Likewise in other tests.
> +static int mode[6] = { 0,
> + PR_FP_MODE_FR,
> + PR_FP_MODE_FR | PR_FP_MODE_FRE,
> + PR_FP_MODE_FR,
> + 0,
> + PR_FP_MODE_FR | PR_FP_MODE_FRE };
Should have braces on separate lines, along the lines of:
static int mode[6] =
{
0,
...
};
Likewise in other tests.
> + if ((float)i != f || (double)i != d)
Missing spaces in casts, "(float) i", "(double) i".
--
Joseph S. Myers
joseph@codesourcery.com