This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING] [PATCH] i686: Fix test suite fails on build by gcc 5.0
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Senkevich, Andrew" <andrew dot senkevich at intel dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Date: Tue, 30 Dec 2014 10:31:15 -0800
- Subject: Re: [PING] [PATCH] i686: Fix test suite fails on build by gcc 5.0
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3sUZH-SF=q_JnjTF6VpJa2f=WVX5-Q8LGLKx=Nqqc5r0A at mail dot gmail dot com> <D373487E0338A646909492FF43BA8BE329748AC1 at CDSMSX102 dot ccr dot corp dot intel dot com>
On Mon, Dec 29, 2014 at 5:45 AM, Senkevich, Andrew
<andrew.senkevich@intel.com> wrote:
> 2014-11-27 20:23 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>> We should also undef SETUP_PIC_REG_STR and LOAD_PIC_REG_STR in
>> sysdeps/i386/sysdep.h for GCC 5, which are defined for C sources and
>> will be wrong for GCC 5.
>
> Attached patch formatted for git am.
>
> ChangeLog:
>
> 2014-12-29 Andrew Senkevich <andrew.senkevich@intel.com>
>
> * sysdeps/i386/tls-macros.h (TLS_IE, TLS_LD, TLS_GD): Keep define in
> PIC mode only if gcc version < 5.0
> * sysdeps/i386/sysdep.h (SETUP_PIC_REG_STR, LOAD_PIC_REG_STR): Keep
> define only if gcc version < 5.0
Do we really need to change SETUP_PIC_REG_STR and
LOAD_PIC_REG_STR? SETUP_PIC_REG_STR is only used
in LOAD_PIC_REG_STR and LOAD_PIC_REG_STR is only used
in check_consistency. I think check_consistency change is
sufficient.
> * sysdeps/unix/sysv/linux/i386/sysdep.h (check_consistency): Likewise.
>
> Is it Ok?
>
>
> --
> Andrew
--
H.J.