This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch, MIPS] Modify memcpy.S for mips32r6/mips64r6
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Steve Ellcey <sellcey at imgtec dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Tue, 23 Dec 2014 18:25:40 +0100
- Subject: Re: [Patch, MIPS] Modify memcpy.S for mips32r6/mips64r6
- Authentication-results: sourceware.org; auth=none
- References: <7ec2bf7e-fc1e-428b-ac0a-747f2a3ab3e6 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot DEB dot 2 dot 10 dot 1412221758190 dot 5278 at digraph dot polyomino dot org dot uk> <1419354526 dot 27606 dot 73 dot camel at ubuntu-sellcey>
On Tue, Dec 23, 2014 at 09:08:46AM -0800, Steve Ellcey wrote:
> On Mon, 2014-12-22 at 17:59 +0000, Joseph Myers wrote:
> > On Fri, 19 Dec 2014, Steve Ellcey wrote:
> >
> > > * sysdeps/mips/memcpy.S: Fix preprocessor indentation.
> >
> > Please separate the formatting fixes from the substantive changes. The
> > formatting fixes - a patch that shows no changes from "git diff -w" - can
> > go in as obvious. The r6 changes should then be resubmitted.
>
> Here is a new memcpy patch. It has just the changes needed for
> mips32r6/mips64r6 support. Note that there are still some preprocessor
> indentation changes where existing ifdefs are now under a newly
> introduced !R6_CODE ifdef.
>
> Tested with the mips32r6/mips64r6 GCC, binutils and qemu simulator.
>
> OK to checkin?
>
still contains likely performance regression. using indirect jumps is
slow, try different approaches.