This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PING^2] [PATCH v3] [BZ #14161] strptime %z ranges


Hello all,

The v3 version of my patches I posted here on Dec 03 addressed
prior concerns raised by Will Newton and Paul Eggert.

1) Patch v3 added tests for the existing problems and their
   correction, as well as the range change.
2) Patch v3 extended the bounds of the conversion for %z string to
   tm_gmtoff +/- 99 hours 59 minutes. Paul felt it needed to be
   at minimum meet other POSIX implementations (+/- 2359 hours)
   so that large historical time offsets could be parsed, and
   did not suggest any upper bound.
3) Patch v3, where commented, uses initial capital, full sentence,
   period and two spaces.

Any additional concerns or constructive comments from anyone?

For reference, the patches are in the mailing list archive at
the URLs listed below:

[PATCH v3 1/4] [BZ #14161] tst-strptime2.c: add %z minute and range limit tests
   https://sourceware.org/ml/libc-alpha/2014-12/msg00097.html

[PATCH v3 2/4] [BZ #16141] strptime: fix %z minutes calculation
   https://sourceware.org/ml/libc-alpha/2014-12/msg00100.html

[PATCH v3 3/4] [BZ #14161] tst-strptime2.c: test %z range to +/-9959
   https://sourceware.org/ml/libc-alpha/2014-12/msg00098.html

[PATCH v3 4/4] [BZ #16141] strptime: extend %z range to +/-9959
   https://sourceware.org/ml/libc-alpha/2014-12/msg00099.html

Thanks,
James
--
James Perkins <james@loowit.net>        www.loowit.net/~james


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]