This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Fix lgammal_r overflow warnings
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 10 Dec 2014 21:17:38 +0000
- Subject: Re: [PATCH] powerpc: Fix lgammal_r overflow warnings
- Authentication-results: sourceware.org; auth=none
- References: <5488959C dot 3010203 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1412101852370 dot 32166 at digraph dot polyomino dot org dot uk> <548898E1 dot 2010208 at linux dot vnet dot ibm dot com>
On Wed, 10 Dec 2014, Adhemerval Zanella wrote:
> +static const long double huge = HUGE_VALL;
No, HUGE_VALL is not correct; that's infinity, which would lose the
overflow exceptions and rounding-mode-dependent results. (And the
ChangeLog entry should name the variable whose initializer is being
changed.)
--
Joseph S. Myers
joseph@codesourcery.com