This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: BZ#16469: resolv: skip leading dot in domain to search

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Alexandre Oliva <aoliva at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Wed, 19 Nov 2014 16:01:37 +0530
Subject: Re: BZ#16469: resolv: skip leading dot in domain to search
Authentication-results: sourceware.org; auth=none
References: <ord28pgw7i dot fsf at free dot home>

On Fri, Nov 14, 2014 at 10:10:25PM -0200, Alexandre Oliva wrote:
> This should only happen if the domain to search is the root,
> represented as "." rather than by an empty string.  Skipping it here
> prevents libc_res_nquerydomain from duplicating the trailing dot,
> which would cause the domain name compression to fail.
> 
> No testcase for this one; we can't really exercise this in a controlled
> fashion without overriding /etc/resolv.conf.
> 
> No regressions on x86_64-linux-gnu.  Ok to install?
> 
> 
> for  ChangeLog
> 
> 	[BZ #16469]
> 	* resolv/res_query.c (__libc_res_nsearch): Skip leading dot in
> 	search domain names.

Looks good to me.

Siddhesh

Attachment: pgpGNmXsjYfZo.pgp
Description: PGP signature

References:
- BZ#16469: resolv: skip leading dot in domain to search
  - From: Alexandre Oliva

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]