This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Add macros for diagnostic control, use them in locale/weightwc.h
- From: Paul Eggert <eggert at cs dot ucla dot edu>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Tue, 18 Nov 2014 15:58:17 -0800
- Subject: Re: Add macros for diagnostic control, use them in locale/weightwc.h
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411181803130 dot 11642 at digraph dot polyomino dot org dot uk> <546BB1B1 dot 50000 at cs dot ucla dot edu> <20141118211808 dot 2053D2C3B22 at topped-with-meat dot com> <546BC831 dot 2010006 at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1411182301110 dot 18922 at digraph dot polyomino dot org dot uk>
On 11/18/2014 03:16 PM, Joseph Myers wrote:
the smallest granularity I expect to be reliable is that of whole statements in source files outside of macros (with the pragma calls on separate lines)
It appears that we've been thinking along parallel lines. I tried some
of the tests that you evidently did, and found that GCC 4.9.2 doesn't
work even then, in that the granularity isn't reliable even for whole
statements, or even for whole functions. This is a regression from GCC
4.8. I filed a bug report here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63943
Disabling for the relevant block of source lines, on all architectures and for all GCC versions that support the relevant -W option, is a pragmatic choice
Yes, and I guess my point is that the pragmatic choice we've taken in
Gnulib is to disable diagnostics at the top level, as GCC has too many
bugs in this area for us to go on wild goose chases trying to fine-tune
diagnostics in smaller areas. I'm skeptical whether it'll be worthwhile
for glibc to chase those geese either, at least in the near future.