This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] hppa: avoid NULL dereference of sym_map in elf_machine_rela()
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Aaro Koskinen <aaro dot koskinen at iki dot fi>
- Cc: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, John David Anglin <dave dot anglin at bell dot net>
- Date: Fri, 31 Oct 2014 14:42:55 -0700 (PDT)
- Subject: Re: [PATCH] hppa: avoid NULL dereference of sym_map in elf_machine_rela()
- Authentication-results: sourceware.org; auth=none
- References: <1414791231-30990-1-git-send-email-aaro dot koskinen at iki dot fi>
It's likely this is not the right fix. Unless there is a test case where
any of those paths can actually dereference a null pointer, then we do not
want to insert those checks.
Rather, the right solution is probably to find (or add) some switch to GCC
that changes what it emits from being a call to abort to be something
different. It's possible that abort is OK and we just need to define an
appropriately minimal abort in rtld. But it needs to be looked into.