This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't use INTDEF/INTUSE with _dl_argv (bug 14132)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 21 Oct 2014 22:06:47 +0000
- Subject: Re: Don't use INTDEF/INTUSE with _dl_argv (bug 14132)
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1410210044550 dot 30508 at digraph dot polyomino dot org dot uk> <mvmlho9x25c dot fsf at hawking dot suse dot de> <Pine dot LNX dot 4 dot 64 dot 1410211237010 dot 17192 at digraph dot polyomino dot org dot uk> <mvmiojdtwxw dot fsf at hawking dot suse dot de> <Pine dot LNX dot 4 dot 64 dot 1410211255150 dot 17192 at digraph dot polyomino dot org dot uk> <mvma94ptpvp dot fsf at hawking dot suse dot de>
On Tue, 21 Oct 2014, Andreas Schwab wrote:
> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>
> > On Tue, 21 Oct 2014, Andreas Schwab wrote:
> >
> >> "Joseph S. Myers" <joseph@codesourcery.com> writes:
> >>
> >> > On Tue, 21 Oct 2014, Andreas Schwab wrote:
> >> >
> >> >> Shouldn't sysdeps/ia64/dl-machine.h be using __GI__dl_argv as well?
> >> >
> >> > I don't know. Since it's not using _dl_argv_internal or INTUSE(_dl_argv)
> >> > at present I see no reason my patch should break it
> >>
> >> It's not about breaking it, it's about making it consistent.
> >
> > That's beyond the scope of what this patch (or patch series) is intended
> > to do.
>
> It's perfectly fitting, just like the other bare _dl_argv reference.
This patch is intended to be minimal - that is, containing *only* the
changes that are necessarily part of eliminating this particular use of
INTDEF/INTUSE. Such a change to sysdeps/ia64/dl-machine.h is clearly not
necessary for this patch.
--
Joseph S. Myers
joseph@codesourcery.com