This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't use INTVARDEF/INTUSE with __libc_enable_secure (bug 14132)
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 10 Oct 2014 05:23:55 +0530
- Subject: Re: Don't use INTVARDEF/INTUSE with __libc_enable_secure (bug 14132)
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1410092318330 dot 14581 at digraph dot polyomino dot org dot uk>
On 10 October 2014 04:49, Joseph S. Myers <joseph@codesourcery.com> wrote:
> Continuing the removal of the obsolete INTDEF / INTVARDEF / INTUSE
> mechanism, this patch replaces its use for __libc_enable_secure with
> the use of rtld_hidden_data_def and rtld_hidden_proto.
>
> Tested for x86_64 that installed stripped shared libraries are
> unchanged by the patch.
>
> 2014-10-09 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #14132]
> * elf/dl-sysdep.c (__libc_enable_secure): Use rtld_hidden_data_def
> instead of INTVARDEF.
> (_dl_sysdep_start): Do not use INTUSE with __libc_enable_secure.
> * sysdeps/mach/hurd/dl-sysdep.c (__libc_enable_secure): Use
> rtld_hidden_data_def instead of INTVARDEF.
> (_dl_sysdep_start): Do not use INTUSE with __libc_enable_secure.
> * elf/dl-deps.c (expand_dst): Likewise.
> * elf/dl-load.c (_dl_dst_count): Likewise.
> (_dl_dst_substitute): Likewise.
> (decompose_rpath): Likewise.
> (_dl_init_paths): Likewise.
> (open_path): Likewise.
> (_dl_map_object): Likewise.
> * elf/rtld.c (dl_main): Likewise.
> (process_dl_audit): Likewise.
> (process_envvars): Likewise.
> * include/unistd.h [IS_IN_rtld] (__libc_enable_secure_internal):
> Remove declaration.
> (__libc_enable_secure): Use rtld_hidden_proto.
Looks good to me.
Thanks,
Siddhesh
--
http://siddhesh.in