Re: [PATCH] Write errors to stdout and not stderr in wcsmbs/tst-mbrtowc.c

[Roland McGrath <roland at hack dot frob dot com>]

> One thing we cannot do is use `dup2' in the skeleton. It might confuse tests
> that specifically test for output written to stdout/stderr. One such example
> is 'posix/tst-getopt_long1.c'.

If need be, we could make it depend on some macros you define before
including the file.  In the one case you cite, it would not break anything.
That test uses freopen to redirect stderr at the stdio level, so it never
writes to fd 2 at all.  So it might well work as a blanket change, but
certainly we should think about it more first.

> > If you'd like to convert these tests to use test-skeleton.c first as a
> > separate change before we figure out how to address the assert issue,
> > that could go in right away.
> 
> Okay. And I see that this itself is a task in the master TODO [1]. I will
> get on it more thoroughly than just these two tests. 

That would be a very fine contribution and there shouldn't be much of
anything to figure out or discuss to get it done.

> In the meanwhile, there are also a lot of tests writing to stderr [2]. If
> we have the policy on that wrapped up, I will work on it next.

> I am sort of new here, by the way. Hello, glibc hackers!

Welcome!  We very much appreciate new contributors.  Have you completed
your copyright assignment paperwork for future contributions to libc?
I don't see your name in copyright.list.  
See https://sourceware.org/glibc/wiki/Contribution%20checklist for
everything you should know.


Thanks,
Roland