Re: [PATCH] remove nested function hack_digit

[Roland McGrath <roland at hack dot frob dot com>]

> hack_digit becomes longer too due to longer function prologue epilogue:

Clearly that cannot be the only difference.  Was the function's code itself
actually all nearly identical, modulo trivial differences like different
register allocation choices?  Each access to one of the parent's locals
surely looks different, and how different that code looks is probably where
the most important differences are.

> I considered doing such a patch but it turned out a huge textual
> change that will make the code much less readable.
> Still, let me do it and send it here anyway, unless you tell me no to.

Of course readability is very subjective, so there really is no substitute
for each interested person just seeing how things look and giving their
opinion.  The most trivial mechanical change might harm readability in ways
that can be improved with a little thought.