This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ARM: Don't define _SYS_AUXV_H in sysdep.h
- From: Will Newton <will dot newton at linaro dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 16 Sep 2014 11:40:35 -0700
- Subject: Re: [PATCH] ARM: Don't define _SYS_AUXV_H in sysdep.h
- Authentication-results: sourceware.org; auth=none
- References: <1410517868-11916-1-git-send-email-will dot newton at linaro dot org> <Pine dot LNX dot 4 dot 64 dot 1409121703270 dot 1118 at digraph dot polyomino dot org dot uk>
On 12 September 2014 10:04, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Fri, 12 Sep 2014, Will Newton wrote:
>
>> sysdep.h was defining _SYS_AUXV_H in order to avoid an include guard check
>> in hwcap.h. Unfortunately it didn't undefine it so it could leak out into
>> code and caused a build failure with -Wimplicit-function-declaration
>> building tst-auxv on ARM.
>>
>> ChangeLog:
>>
>> 2014-09-11 Will Newton <will.newton@linaro.org>
>>
>> * sysdeps/unix/sysv/linux/arm/bits/hwcap.h: Check for
>> _LINUX_ARM_SYSDEP_H include guard too.
>
> Rather than referring to a guard for an internal header in an installed
> header, I think it would be better to test for _LIBC there.
This approach (testing for the sysdep.h guard) is used in sparc and
powerpc at present. Testing _LIBC would work but
stdio-common/scanf15.c and stdio-common/scanf17.c both #undef _LIBC
and break things.
--
Will Newton
Toolchain Working Group, Linaro