This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Cleanup MIPS preconfigure script
- From: Steve Ellcey <sellcey at mips dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, <libc-alpha at sourceware dot org>, <matthew dot fortune at imgtec dot com>, Catherine Moore <clm at codesourcery dot com>
- Date: Tue, 9 Sep 2014 10:13:54 -0700
- Subject: Re: [PATCH] Cleanup MIPS preconfigure script
- Authentication-results: sourceware.org; auth=none
- References: <6b5ce132-2a69-4ee9-aaa5-d07792e72b50 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot DEB dot 1 dot 10 dot 1409042322000 dot 27075 at tp dot orcam dot me dot uk> <1409871127 dot 2740 dot 76 dot camel at ubuntu-sellcey> <alpine dot DEB dot 1 dot 10 dot 1409050002390 dot 27075 at tp dot orcam dot me dot uk> <1409948236 dot 2740 dot 110 dot camel at ubuntu-sellcey> <Pine dot LNX dot 4 dot 64 dot 1409052152480 dot 20739 at digraph dot polyomino dot org dot uk> <1410279506 dot 2740 dot 158 dot camel at ubuntu-sellcey> <alpine dot DEB dot 1 dot 10 dot 1409091806340 dot 27075 at tp dot orcam dot me dot uk>
On Tue, 2014-09-09 at 18:08 +0100, Maciej W. Rozycki wrote:
> On Tue, 9 Sep 2014, Steve Ellcey wrote:
>
> > +if test "$abiflag" != "_ABIO32" -a "$mips16flag" = "1"; then
> > + as_fn_error $? "mips16 is only supported with the O32 ABI." "$LINENO" 5
> > +fi
>
> Hmm, I think the capitalisation is weird here, why not:
>
> + as_fn_error $? "MIPS16 is only supported with the o32 ABI." "$LINENO" 5
>
> ?
>
> Maciej
I already checked it in but I can go back and tweak the capitalization
if you want.
Steve Ellcey
sellcey@mips.com