This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Cleanup MIPS preconfigure script
- From: Steve Ellcey <sellcey at mips dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "Maciej W. Rozycki" <macro at codesourcery dot com>, <libc-alpha at sourceware dot org>, <matthew dot fortune at imgtec dot com>, Catherine Moore <clm at codesourcery dot com>
- Date: Fri, 5 Sep 2014 15:36:53 -0700
- Subject: Re: [PATCH] Cleanup MIPS preconfigure script
- Authentication-results: sourceware.org; auth=none
- References: <6b5ce132-2a69-4ee9-aaa5-d07792e72b50 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot DEB dot 1 dot 10 dot 1409042322000 dot 27075 at tp dot orcam dot me dot uk> <1409871127 dot 2740 dot 76 dot camel at ubuntu-sellcey> <alpine dot DEB dot 1 dot 10 dot 1409050002390 dot 27075 at tp dot orcam dot me dot uk> <1409948236 dot 2740 dot 110 dot camel at ubuntu-sellcey> <Pine dot LNX dot 4 dot 64 dot 1409052152480 dot 20739 at digraph dot polyomino dot org dot uk>
On Fri, 2014-09-05 at 21:55 +0000, Joseph S. Myers wrote:
> On Fri, 5 Sep 2014, Steve Ellcey wrote:
>
> > I agree, here is a new patch. I complete removed the setting of
> > base_machine since it is not used and I removed the line:
>
> base_machine *is* used, to set base-machine in config.make. But the only
> things that's used for now are (mach/Makefile for powerpc and) libc-abis
> handling (regarding which see
> <https://sourceware.org/ml/libc-alpha/2014-01/msg00375.html>) - and
> whatever the libc-abis handling does or does not work for, there is no use
> in a special setting of base_machine for mips64; just setting to mips for
> all MIPS cases seems most appropriate and consistent with other
> architectures.
OK, I will put 'base_machine=mips' back in. I also found a problem with
my removal of
machine=$machine/$config_machine
Everything was fine building mips-mti-linux-gnu and mips-linux-gnu but I
forgot to rebuild mips64-linux-gnu. When I did it failed because
sysdeps/unix/sysv/linux/mips/configure.ac contains:
case $machine in
mips/mips64/n64/*)
LIBC_SLIBDIR_RTLDDIR([lib64], [lib64])
;;
mips/mips64/n32/*)
LIBC_SLIBDIR_RTLDDIR([lib32], [lib32])
;;
esac
and if machine is set to 'mips/mips64/n64' or 'mips/mips64/n32' it
doesn't match the case statements. I am not sure if I should put
the 'machine=$machine/$config_machine' line back or change the
case statement to match n64* and n32* instead of n64/* and n32/*.
Opinions?
Steve Ellcey